Pass the current windowId to the subPanels
#2899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piroor
reviewed
Jun 1, 2021
|
Thanks! This looks very reasonable change. Could you see my comment about the prefix? |
|
Thanks again! |
|
Ok. Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could not figure out a generic way for the
subPanelto determine the id of the window it is in, ouside situations where it happens to be known to be thecurrentWindow.There would be multiple possible ways for TST to pass that information. As far as I can tell, there is no direct RPC between the subpanel content and the sidebar yet. A simple
postMessageby the sidebar would be sub-optimal, because the panel content might not be listening yet.So I figured a URL query parameter is a simple way to transfer this information.
This information expects the
subPanel.urlto be a valid URL.