Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't close about:treestyletab-group tab for single tab group without other tabs #537

Closed
Infocatcher opened this issue Aug 1, 2013 · 7 comments

Comments

@Infocatcher
Copy link
Contributor

I want ability to leave about:treestyletab-group tab in following case:

[about:treestyletab-group]
    [Child tab #1]
    [Child tab #2]

(no other tabs around)
E.g. I opened some bookmarks folder "as a New Tree" and then close initial tab (to get structure described above). And about:treestyletab-group automatically closes.

So I prefer to automatically close only about:treestyletab-group tabs without child tabs.

piroor added a commit that referenced this issue Aug 20, 2013
…the group is closed. (#537)

This behaviour can be disabled (and get the old behaviour) by setting the preference "extensions.treestyletab.autoRemoveNeedlessGroupTab.lastTab" to "true".
@Infocatcher
Copy link
Contributor Author

Hmm... I probably provide poor description, sorry.

Start Firefox or open new window:

[Initial tab]

Then open any bookmarks folder (I'm use middle-click on bookmarks folder) "as a New Tree":

[Initial tab]
[about:treestyletab-group]
    [Child tab #1]
    [Child tab #2]

Then close "Initial tab" ("about:treestyletab-group" tab will be automatically closed):

[Child tab #1]
[Child tab #2]

And I want to see

[about:treestyletab-group]
    [Child tab #1]
    [Child tab #2]

@Infocatcher
Copy link
Contributor Author

I'm use browser.tabs.closeWindowWithLastTab = false, so I don't need extensions.treestyletab.autoRemoveNeedlessGroupTab.lastTab, but I found it useful. :)

@piroor
Copy link
Owner

piroor commented Aug 21, 2013

Oh, sorry, I misunderstood the initial comment!

It is a feature introduced by the commit c419a3f. Because I think group tabs are just temporary, I decided to clean up needless groups automatically. However, people who use group tabs to manage tree manually can stressed by it. So now I'm planning to add another secret preference to disable this "automatic cleanup" feature.

piroor added a commit that referenced this issue Aug 21, 2013
…hild of the group is closed. (#537)"

This reverts commit 63a72c9.
@piroor
Copy link
Owner

piroor commented Aug 21, 2013

Instead, I've introduced the concept "temporary group tab" and "permanent group tab". Now TST closes needless group tabs only when it is marked as "temporary". I think this is better than new customizability around the autoremove behaviour. How about this?

@Infocatcher
Copy link
Contributor Author

Instead, I've introduced the concept "temporary group tab" and "permanent group tab".

Not bad. I'm not annoying with auto-closing of dummy tabs without children (remove last child tab => automatically close dummy parent tab), but it's easy to close them manually.
But I also prefer to have an option for temporary=false by default.

And why about:treestyletab-group?title=...;temporary=true and not about:treestyletab-group?title=...&temporary=true? Second looks more standard.

@piroor
Copy link
Owner

piroor commented Aug 21, 2013

Now you can change the default behaviour. See: dec4d77

And why about:treestyletab-group?title=...;temporary=true and not about:treestyletab-group?title=...&temporary=true? Second looks more standard.

I misunderstood the spec...
http://en.wikipedia.org/wiki/Query_string#Web_forms

@Infocatcher
Copy link
Contributor Author

Now you can change the default behaviour.

Great, thanks!

I misunderstood the spec...
http://en.wikipedia.org/wiki/Query_string#Web_forms

Interesting, I never (very-very rare?) see ; in links on web pages.

@piroor piroor closed this as completed Aug 21, 2013
Infocatcher added a commit to Infocatcher/treestyletab that referenced this issue Aug 21, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants