-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't close about:treestyletab-group tab for single tab group without other tabs #537
Comments
…the group is closed. (#537) This behaviour can be disabled (and get the old behaviour) by setting the preference "extensions.treestyletab.autoRemoveNeedlessGroupTab.lastTab" to "true".
Hmm... I probably provide poor description, sorry. Start Firefox or open new window:
Then open any bookmarks folder (I'm use middle-click on bookmarks folder) "as a New Tree":
Then close "Initial tab" ("about:treestyletab-group" tab will be automatically closed):
And I want to see
|
I'm use browser.tabs.closeWindowWithLastTab = false, so I don't need extensions.treestyletab.autoRemoveNeedlessGroupTab.lastTab, but I found it useful. :) |
Oh, sorry, I misunderstood the initial comment! It is a feature introduced by the commit c419a3f. Because I think group tabs are just temporary, I decided to clean up needless groups automatically. However, people who use group tabs to manage tree manually can stressed by it. So now I'm planning to add another secret preference to disable this "automatic cleanup" feature. |
Instead, I've introduced the concept "temporary group tab" and "permanent group tab". Now TST closes needless group tabs only when it is marked as "temporary". I think this is better than new customizability around the autoremove behaviour. How about this? |
Not bad. I'm not annoying with auto-closing of dummy tabs without children (remove last child tab => automatically close dummy parent tab), but it's easy to close them manually. And why |
Now you can change the default behaviour. See: dec4d77
I misunderstood the spec... |
Great, thanks!
Interesting, I never (very-very rare?) see |
I want ability to leave about:treestyletab-group tab in following case:
(no other tabs around)
E.g. I opened some bookmarks folder "as a New Tree" and then close initial tab (to get structure described above). And about:treestyletab-group automatically closes.
So I prefer to automatically close only about:treestyletab-group tabs without child tabs.
The text was updated successfully, but these errors were encountered: