-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply "Open new blank tab as ..." option for "Ctrl-T" #1038
Comments
I see that I can use the option to add blank tabs always as a child of the current tab. The sequence is then to select a parent tab and then press |
Did you close this unexpectedly? If you like, you can assign "open new child tab" to middle-click on the "+" button. Sadly, you cannot do similar config for the keyboard shortcut like Ctrl-Shift-T - it is already used for "undo close tab". |
I closed it because I thought I found an alternative solution, but for some reason it is not working: new blank tabs created with So yes, it might still make sense to have a context menu option to insert a blank tab, where clicking this menu option would be equivalent to clicking the tab and pressing |
BTW my another addon New Tab from Location Bar https://addons.mozilla.org/firefox/addon/new-tab-from-location-bar/ possibly helps you. It provides ability to open new child tab when you type an URL into the location bar. And, if you hope to open a link or an URL text in the current page as new sibling tab, you can do it by drag the link (or the URL text) and drop it between existing tabs. |
I'm trying to figure whether Currently, I have it set as (new version on FF58)
... and it doesn't seem to do anything, |
The option works for the "new tab" button in the sidebar. We need to do something more for Ctrl-T case.,, |
Currently it is impossible to know the reason why a new tab is opened. So we need to suppose to the reason from something available hints. For example: Adding new option like |
Yea maybe something like that. Note that new tabs can be overridden (e.g. 'New Tab Override' extension) to something like |
Done by recent commits. |
There is another problem that a new next sibling tab breaks tree structure, hmm... |
Recent commits fixes the invalid positioning problem, and we've reached at the goal: Apply "Open new blank tab as ..." option for "Ctrl-T". One left problem is: if you hit Ctrl-T multiple times quickly, then they will be uncontrolled, because such new tabs are opened with a URL "about:blank" instead of "about:newtab". Firefox always prepares one new blank tab with the URL "about:newtab" in the background for quick response, and after you actually open a new blank tab, there is no more prepared new tab. If you hit new Ctrl-T before the next "about:newtab" tab is completely prepared, Firefox opens an "about:blank" tab and loads "about:newtab" after the tab is opened. Then we cannot detect the tab is actually opened by Ctrl-T or opened by other reasons like bookmarks. (Actually new tab opened from bookmark is also created with "about:blank" URL at first.) Sadly there is no solution to resolve this problem, this is a limitation of WebExtensions API system. |
That's probably "ok" since spamming Ctrl-T is a questionable exercise anyway... Just out of wonder, how quickly is "quickly"? |
Currently I have no answer - we need to research the trigger to prepare new blank tab in the background. |
I close this because this is too old and not match to the latest maintained version of TST. |
Currently, to add a blank tab to a Tree, I press
Ctrl+T
to open a new tab window, and then move it into the desired Tree. What I would like to do is to right-click the Tree and chooseAdd new Tab
, which should insert a blank Tab into that Tree (as a child of the Tree). This would be more direct and less fiddly.The text was updated successfully, but these errors were encountered: