This repository has been archived by the owner on Nov 7, 2018. It is now read-only.
Stateful masters #211
Merged
Stateful masters #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pires
suggested changes
Aug 20, 2018
stateful/es-master-stateful.yaml
Outdated
| @@ -0,0 +1,79 @@ | |||
| apiVersion: apps/v1beta1 | |||
There was a problem hiding this comment.
Please, move to apps/v1. Also, please do this for es-data-stateful.yaml.
stateful/README.md
Outdated
|
|
||
| ## Storage | ||
|
|
||
| The [`es-data-stateful.yaml`](es-data-stateful.yaml) file contains a `volumeClaimTemplates` section which requests a 12 GB disk. This is plenty of space for a demonstration cluster, but will fill up quickly under moderate to heavy load. Consider modifying the disk size to your needs. | ||
| The [`es-data-stateful.yaml`](es-data-stateful.yaml) and [`es-master-stateful.yaml`](es-master-stateful.yaml) files contain `volumeClaimTemplates` sections which request a 12 GB (2 GB for master pods) disks. This is plenty of space for a demonstration cluster, but will fill up quickly under moderate to heavy load. Consider modifying the disk size to your needs. |
There was a problem hiding this comment.
Suggestion for the sake of clarity:
volumeClaimTemplatessections which request 2GB volume for each master node, and 12GB volume for each data node.
|
Made the suggested changes @pires |
pires
approved these changes
Aug 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again Paulo :)
After your reply on issue #210, I've created stateful/es-master-stateful.yaml file which deploys master nodes as a 3 replica StatefulSet and attaches 2GB disk to each pod for persisting cluster state.
I've also edited the stateful readme file to mention master deployment as well.
Cheers!