message added for the same ports for Micro #2626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Thihup Can you review my mr please? Thanks |
|
As this is your first PR can you please acknowledge that the code will be owned by Manorrock.com. I will only ask this one time as that is all that is needed for contributing code back to us. |
|
Hi @Thihup |
|
@salmansharifov Unfortunately 'no problem' is not enough as an acknowledgement. Please say something like 'I acknowledge the code will be owned by Manorrock.com' and then we can proceed to merge your first contribution which is very much appreciated! |
|
I acknowledge the code will be owned by Manorrock.com |
|
@Thihup Go ahead and merge at your discretion! |
mnriem
approved these changes
Jun 30, 2022
|
@salmansharifov Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required
Associated issue: #2620