Fixes #4270 - Cleanup various bits (#4272)

piranhacloud · Nov 25, 2024 · ac38f06 · ac38f06
1 parent 2d498ed
commit ac38f06
Show file tree

Hide file tree

Showing 10 changed files with 14 additions and 10 deletions.
diff --git a/.../core/src/test/java/org/jboss/weld/tck/piranha/PiranhaDeploymentExceptionTransformer.java b/.../core/src/test/java/org/jboss/weld/tck/piranha/PiranhaDeploymentExceptionTransformer.java
@@ -60,6 +60,7 @@ public class PiranhaDeploymentExceptionTransformer implements DeploymentExceptio
 
     @Override
     public Throwable transform(Throwable throwable) {
+        @SuppressWarnings("unchecked")
         List<Throwable> throwableList = ExceptionUtils.getThrowableList(throwable);
         if (throwableList.size() < 1)
             return throwable;

diff --git a/feature/isolatedwebapp/src/main/java/module-info.java b/feature/isolatedwebapp/src/main/java/module-info.java
@@ -36,7 +36,7 @@
     exports cloud.piranha.feature.isolatedwebapp;
     opens cloud.piranha.feature.isolatedwebapp;    
     requires cloud.piranha.feature.impl;
-    requires cloud.piranha.http.webapp;
+    requires transitive cloud.piranha.http.webapp;
     requires cloud.piranha.micro.builder;
     requires cloud.piranha.micro.loader;
     requires shrinkwrap.api;

diff --git a/feature/webapps/src/main/java/cloud/piranha/feature/webapps/WebAppsFeature.java b/feature/webapps/src/main/java/cloud/piranha/feature/webapps/WebAppsFeature.java
@@ -34,6 +34,7 @@
 import cloud.piranha.http.api.HttpServerProcessor;
 import cloud.piranha.http.webapp.HttpWebApplicationServer;
 import java.io.File;
+import java.lang.System.Logger.Level;
 import java.util.ArrayList;
 
 /**
@@ -107,6 +108,10 @@ public HttpWebApplicationServer getHttpWebApplicationServer() {
 
     @Override
     public void init() {
+        if (LOGGER.isLoggable(Level.DEBUG)) {
+            LOGGER.log(Level.DEBUG, "Initializing WebAppsFeature");
+        }
+
         if (webApplicationServer == null) {
             webApplicationServer = new HttpWebApplicationServer();
         }

diff --git a/http/crac/src/main/java/module-info.java b/http/crac/src/main/java/module-info.java
@@ -41,6 +41,6 @@
 
     exports cloud.piranha.http.crac;
     opens cloud.piranha.http.crac;
-    requires cloud.piranha.http.api;
-    requires org.crac;
+    requires transitive cloud.piranha.http.api;
+    requires transitive org.crac;
 }
diff --git a/http/netty/src/main/java/cloud/piranha/http/netty/NettyHttpServerHandler.java b/http/netty/src/main/java/cloud/piranha/http/netty/NettyHttpServerHandler.java
@@ -94,6 +94,7 @@ public void channelReadComplete(ChannelHandlerContext context) {
     @Override
     protected void channelRead0(ChannelHandlerContext context, FullHttpRequest object) {
         NettyHttpServerRequest nettyRequest = new NettyHttpServerRequest(context, object, secure);
+        @SuppressWarnings("deprecation")
         FullHttpResponse response = new DefaultFullHttpResponse(HTTP_1_1, OK, true);
         NettyHttpServerResponse nettyResponse = new NettyHttpServerResponse(response);
         httpServerProcessor.process(nettyRequest, nettyResponse);

diff --git a/http/virtual/src/main/java/module-info.java b/http/virtual/src/main/java/module-info.java
@@ -36,6 +36,6 @@
 
     exports cloud.piranha.http.virtual;
     opens cloud.piranha.http.virtual;
-    requires cloud.piranha.http.api;
+    requires transitive cloud.piranha.http.api;
     requires cloud.piranha.http.impl;
 }
diff --git a/http/webapp/src/main/java/cloud/piranha/http/webapp/HttpWebApplicationOutputStream.java b/http/webapp/src/main/java/cloud/piranha/http/webapp/HttpWebApplicationOutputStream.java
@@ -96,6 +96,7 @@ public void writeStatusLine() throws IOException {
         httpServerResponse.writeStatusLine();
     }
 
+    @SuppressWarnings("removal")
     @Override
     public void writeHeaders() throws IOException {
 

diff --git a/http/webapp/src/main/java/cloud/piranha/http/webapp/HttpWebApplicationResponse.java b/http/webapp/src/main/java/cloud/piranha/http/webapp/HttpWebApplicationResponse.java
@@ -47,7 +47,7 @@ public class HttpWebApplicationResponse extends DefaultWebApplicationResponse {
     /**
      * Stores the wrapped HttpServerResponse.
      */
-    private final HttpServerResponse wrapped;
+    protected final HttpServerResponse wrapped;
 
     /**
      * Constructor.

diff --git a/maven/plugin/src/main/java/cloud/piranha/maven/plugin/BaseMojo.java b/maven/plugin/src/main/java/cloud/piranha/maven/plugin/BaseMojo.java
@@ -186,6 +186,7 @@ protected String createArtifactPath(
      * @return the URL.
      * @throws IOException when an I/O error occurs.
      */
+    @SuppressWarnings("deprecation")
     protected URL createMavenCentralArtifactUrl(String groupId, String artifactId,
             String version, String type) throws IOException {
         return new URL("https://repo1.maven.org/maven2/"

diff --git a/test/micro/snoop/src/test/java/snoop/SnoopIT.java b/test/micro/snoop/src/test/java/snoop/SnoopIT.java
@@ -44,11 +44,6 @@
  */
 public class SnoopIT {
 
-    /**
-     * Stores the process.
-     */
-    static private Process process;
-
     /**
      * Stores the port
      */