satellite: remove useless readiness probe #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WanzenBug
force-pushed
the
remove-satellite-readiness-probe
branch
from
f2ea2e5
to
9265e10
Compare
The readiness probe was implemented as a connection check on the satellites's comm-port. This turned out to cause issues, as the satellite only expects a single connection (from the controller). The most visible issues occured when using SSL, as the readiness probe would not complete the TLS handshake, generating repeated error reports. Since the open comm-port doesn't actually tell us all that much about the satellites readiness, other than that it completed start-up, we don't lose very much by just removing it. Note that a solution querying the Controller API was considered, but discarded, as it would almost certainly propagate any Controller errors to the readiness state, causing satellites to be recreated when they actually work fine. Signed-off-by: Moritz "WanzenBug" Wanzenböck <[email protected]>
WanzenBug
force-pushed
the
remove-satellite-readiness-probe
branch
from
9265e10
to
2eaa6fa
Compare
JoelColledge
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The readiness probe was implemented as a connection check on the satellites's
comm-port. This turned out to cause issues, as the satellite only expects a
single connection (from the controller). The most visible issues occured
when using SSL, as the readiness probe would not complete the TLS handshake,
generating repeated error reports.
Since the open comm-port doesn't actually tell us all that much about
the satellites readiness, other than that it completed start-up, we don't
lose very much by just removing it.
Note that a solution querying the Controller API was considered, but discarded,
as it would almost certainly propagate any Controller errors to the
readiness state, causing satellites to be recreated when they actually work
fine.
Closes #181