-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 454 #472
Fix 454 #472
Conversation
…_whole_package_to_whitelist
- Uses the whitelist of WhitelistObjectInputStream.java to setup the filter of XStream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes should not be part of this branch. Sorry.
Pull Request Test Coverage Report for Build 1025
💛 - Coveralls |
@mhagnumdw The last commit should have fixed this now. |
@rygel |
I made the modifications. |
I modified the pippo-demo-basic, to use xstream instead of jackson (add <dependency>
<groupId>ro.pippo</groupId>
<artifactId>pippo-xstream</artifactId>
<version>${pippo.version}</version>
</dependency>
<dependency>
<groupId>ro.pippo</groupId>
<artifactId>pippo-jackson</artifactId>
<version>${pippo.version}</version>
</dependency> and I see that |
@decebals So no exception has been thrown? I just checked the XStream documentation (http://x-stream.github.io/security.html) and I think I forgot a crucial part, while working on the fix. // clear out existing permissions and set own ones
xstream.addPermission(NoTypePermission.NONE); I think XStream already is setup with some default permissions and to get the highest securit thoe have to be cleared first, before adding the own/new ones. Sorry for my oversight. I created a new PR for this. |
This is my take on fixing this bug. I've added regular expression parsing and re-using WhitelistObjectInputStream.