feat(genesis): mainnet values in gen alloc and testing #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ramarti
requested review from
LeoHChen,
AndyBoWu,
jdubpark,
edisonz0718,
ezreal1997,
limengformal,
0xHansLee and
leeren
as code owners
Ramarti
force-pushed
the
fix-gen-alloc
branch
from
ccd4b8e to
0d3f31e
Compare
edisonz0718
reviewed
Dec 17, 2024
| address[] memory proposers = new address[](1); | ||
| proposers[0] = protocolAdmin; | ||
| address[] memory executors = new address[](1); | ||
| executors[0] = timelockExecutor; |
There was a problem hiding this comment.
Is it setting it to anyone can execute?
There was a problem hiding this comment.
It allows having address(0) in env files so it's public
story/contracts/script/GenerateAlloc.s.sol
Line 132 in 0ac4627
Ramarti
force-pushed
the
fix-gen-alloc
branch
from
0ac4627 to
3eb131a
Compare
Ramarti
force-pushed
the
fix-gen-alloc
branch
from
3eb131a to
1e68dd2
Compare
jdubpark
reviewed
Dec 18, 2024
| // Optionally allocate 10k test accounts for devnets/testnets | ||
| bool private constant ALLOCATE_10K_TEST_ACCOUNTS = false; | ||
| // Optionally keep the timelock admin role for testnets | ||
| bool private constant KEEP_TIMELOCK_ADMIN_ROLE = true; | ||
|
|
||
| /// @notice this call should only be available from Test.sol, for speed | ||
| function disableStateDump() external { | ||
| require(block.chainid == 31337, "Only for local tests"); | ||
| require(block.chainid == ChainIds.FOUNDRY, "Only for local tests"); | ||
| saveState = false; | ||
| } | ||
|
|
||
| /// @dev this call should only be available from Test.sol | ||
| function setAdminAddresses(address protocol, address executor, address guardian) external { |
There was a problem hiding this comment.
FWIW, we could write to internal storage slots directly in tests (but having setAdminAddresses in script doesn't impact performance or anything).
jdubpark
approved these changes
Dec 18, 2024
limengformal
approved these changes
Dec 18, 2024
Binary uploaded successfully 🎉📦 Version Name: 0.14.1-unstable-e9da1b4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KEEP_TIMELOCK_ADMIN_ROLE = true)issue: none