chore(gomod): rollback cometbft to v0.38.9 #406
Conversation
0xHansLee
requested review from
LeoHChen,
AndyBoWu,
jdubpark,
edisonz0718,
ezreal1997,
limengformal and
leeren
as code owners
| @@ -23,7 +23,7 @@ require ( | |||
| github.com/cosmos/cosmos-sdk v0.50.7 | |||
| github.com/cosmos/gogoproto v1.7.0 | |||
| github.com/decred/dcrd/dcrec/secp256k1/v4 v4.3.0 | |||
| github.com/ethereum/go-ethereum v1.14.8 | |||
There was a problem hiding this comment.
Do we also need to rollback geth version?
There was a problem hiding this comment.
Yes, because of the compatibility issue of btcec.
cometbft v0.38.9 uses v2.2.0 of btcec, but go-ethereum v1.14.8 uses v2.3.4 of btcec, which is not backward compatible.
|
do we also need to rollback cosmos-sdk to |
It was (but not required). But it seems v0.50.10 is also compatible with cometbft v0.38.9 (57block tested). So I just revert cometbft since there are some changes you made in cosmos-sdk as well. |
edisonz0718
force-pushed
the
hans/rollback-cometbft
branch
from
b1fdfaa to
172c5ff
Compare
Binary uploaded successfully 🎉📦 Version Name: 0.13.2-unstable-450dcce |
After upgrading cometbft to v0.38.12, we encountered
sent next PEX request too soonerror.Before fixing this issue, I would like to rollback the cometbft to v0.38.9 (go-ethereum and btcec as well since there are related breaking changes from v0.38.9 to v0.38.12).
issue: none