feat(docker): add dockerfile and workflow #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wo-o
requested review from
LeoHChen,
AndyBoWu,
jdubpark,
edisonz0718,
ezreal1997,
limengformal and
leeren
as code owners
ezreal1997
approved these changes
Nov 6, 2024
Dockerfile
Outdated
| RUN apk add --no-cache ca-certificates | ||
| COPY --from=builder /story/story /usr/local/bin/ | ||
|
|
||
| EXPOSE 8545 8546 30303 30303/udp |
There was a problem hiding this comment.
these ports seem to be the port of geth? maybe we need to expose the ports used by story
There was a problem hiding this comment.
It could be. On CL side, 26656 for p2p and 26657 for rpc. In addition, 1317 (by default) for API should be opened for providing API service.
There was a problem hiding this comment.
I changed expose port. Thanks!
Binary uploaded successfully 🎉📦 Version Name: 0.12.2-unstable-7ab955a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear team, I have created dockerfile and worflow to make story image.
The REPOSITORY_URI environment and GITHUB_TOKEN secret needed to be set up to run the workflow.
issue: none