fix(ci): delete iliad binary upload workflow #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edisonz0718
requested review from
LeoHChen,
AndyBoWu,
jdubpark,
ezreal1997,
limengformal and
leeren
as code owners
jdubpark
approved these changes
Aug 22, 2024
|
We should create |
We have https://github.com/piplabs/story/blob/main/.github/workflows/ci-s3.yml |
edisonz0718
force-pushed
the
ze/delete-old-binary-upload-workflow
branch
from
d203c20 to
d3c5871
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This workflow still pushes binary to the old S3 bucket which mixes with the old binaries
issue: none