Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(evmstaking): using pubkey instead address #249

Merged
merged 8 commits into from
Oct 20, 2024
Merged

feat(evmstaking): using pubkey instead address #249

merged 8 commits into from
Oct 20, 2024

Conversation

jhd2best
Copy link
Collaborator

  • all staking and distribution API interface use pubkey instead of address
  • add get delegator info API interface

issue: none

0xHansLee
0xHansLee approved these changes Oct 20, 2024
View reviewed changes
Copy link
Contributor

@0xHansLee 0xHansLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, excepting the failure of go lint action

@jhd2best jhd2best force-pushed the haodi/api-using-pubkey-instead-address branch from 1f4ffad to 29f2726 Compare October 20, 2024 05:38
@jhd2best jhd2best merged commit a73c638 into main Oct 20, 2024
6 checks passed
@jhd2best jhd2best deleted the haodi/api-using-pubkey-instead-address branch October 20, 2024 05:41
@github-actions GitHub Actions
Copy link

Binary uploaded successfully 🎉

📦 Version Name: 0.12.1-unstable-a73c638
📦 Download Source: AWS S3

ezreal1997 added a commit that referenced this pull request Oct 21, 2024
@ezreal1997
Revert "feat(evmstaking): using pubkey instead address (#249)"
8085ace 
This reverts commit a73c638.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xHansLee 0xHansLee 0xHansLee approved these changes

@edisonz0718 edisonz0718 edisonz0718 approved these changes

@LeoHChen LeoHChen Awaiting requested review from LeoHChen LeoHChen is a code owner

@AndyBoWu AndyBoWu Awaiting requested review from AndyBoWu AndyBoWu is a code owner

@jdubpark jdubpark Awaiting requested review from jdubpark jdubpark is a code owner

@ezreal1997 ezreal1997 Awaiting requested review from ezreal1997 ezreal1997 is a code owner

@limengformal limengformal Awaiting requested review from limengformal limengformal is a code owner

@leeren leeren Awaiting requested review from leeren leeren is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhd2best @edisonz0718 @0xHansLee