Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(genesis): disable vote extension by default #173

Merged
merged 1 commit into from
Oct 7, 2024
Merged

feat(genesis): disable vote extension by default #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion client/genutil/defaults.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import "github.com/cometbft/cometbft/types"
// DefaultConsensusParams returns the default cometBFT consensus params for story protocol.
func DefaultConsensusParams() *types.ConsensusParams {
resp := types.DefaultConsensusParams()
resp.ABCI.VoteExtensionsEnableHeight = 1 // Enable vote extensions from the start.
resp.Validator.PubKeyTypes = []string{types.ABCIPubKeyTypeSecp256k1} // Only k1 keys.
resp.Block.MaxBytes = -1 // Disable max block bytes, since we MUST include the whole EVM block, which is limited by max gas per block.

Expand Down
2 changes: 1 addition & 1 deletion client/genutil/genutil_internal_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import (
func TestDefaultConsensusParams(t *testing.T) {
t.Parallel()
cons := defaultConsensusGenesis()
require.EqualValues(t, 1, cons.Params.ABCI.VoteExtensionsEnableHeight)
require.EqualValues(t, 0, cons.Params.ABCI.VoteExtensionsEnableHeight)
require.EqualValues(t, types.ABCIPubKeyTypeSecp256k1, cons.Params.Validator.PubKeyTypes[0])
require.EqualValues(t, -1, cons.Params.Block.MaxBytes)
require.EqualValues(t, -1, cons.Params.Block.MaxGas)
Expand Down
2 changes: 1 addition & 1 deletion lib/netconf/iliad/genesis.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"app": "0"
},
"abci": {
"vote_extensions_enable_height": "1"
"vote_extensions_enable_height": "0"
}
},
"app_hash": "",
Expand Down
2 changes: 1 addition & 1 deletion lib/netconf/local/genesis.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"app": "0"
},
"abci": {
"vote_extensions_enable_height": "1"
"vote_extensions_enable_height": "0"
}
},
"app_hash": "",
Expand Down
2 changes: 1 addition & 1 deletion lib/tutil/testdata/genesis.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
]
},
"abci": {
"vote_extensions_enable_height": "1"
"vote_extensions_enable_height": "0"
},
"version": {}
},
Expand Down
Loading