Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(evmstaking): add test cases for genesis #111

Merged
merged 2 commits into from
Sep 19, 2024
Merged

test(evmstaking): add test cases for genesis #111

merged 2 commits into from
Sep 19, 2024

Conversation

zsystm
Copy link
Collaborator

@zsystm zsystm commented Sep 12, 2024 •
edited
Loading

increased coverage to 71.4%

not covered

  • sdk related errors
    • failed to set values to the store
    • failed to initialize withdraw queue
    • corrupted value was in staking module's state
    • failed to get values from store

issue: #64

@zsystm zsystm force-pushed the zsystm/test/evmstaking/keeper/genesis branch from 60c501f to 927b4c4 Compare September 12, 2024 00:53
@zsystm zsystm marked this pull request as ready for review September 12, 2024 01:17
@zsystm zsystm self-assigned this Sep 12, 2024
@zsystm zsystm changed the title test(evmstaking/keeper): add test cases for genesis test(evmstaking): add test cases for genesis Sep 18, 2024
@zsystm
add test cases for genesis
dd1900a 
increased coverage to 71.4%
@zsystm zsystm force-pushed the zsystm/test/evmstaking/keeper/genesis branch from 927b4c4 to dd1900a Compare September 19, 2024 06:28
@zsystm zsystm merged commit ccd5834 into piplabs:main Sep 19, 2024
6 checks passed
@zsystm zsystm mentioned this pull request Sep 22, 2024
Closed
@zsystm zsystm deleted the zsystm/test/evmstaking/keeper/genesis branch September 25, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdubpark jdubpark jdubpark approved these changes

@edisonz0718 edisonz0718 edisonz0718 approved these changes

@LeoHChen LeoHChen Awaiting requested review from LeoHChen LeoHChen is a code owner

@AndyBoWu AndyBoWu Awaiting requested review from AndyBoWu AndyBoWu is a code owner

@ezreal1997 ezreal1997 Awaiting requested review from ezreal1997 ezreal1997 is a code owner

@limengformal limengformal Awaiting requested review from limengformal limengformal is a code owner

@Narangde Narangde Awaiting requested review from Narangde

@leeren leeren Awaiting requested review from leeren leeren is a code owner

Assignees

@zsystm zsystm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zsystm @edisonz0718 @jdubpark