-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(contracts): add event params & make explicit un/cmp names #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdubpark
force-pushed
the
jdub/emit-more-params-in-stake-events
branch
2 times, most recently
from
August 22, 2024 18:21
c60c783
to
c5c2af7
Compare
jdubpark
requested review from
LeoHChen,
AndyBoWu,
edisonz0718,
ezreal1997,
limengformal and
leeren
as code owners
August 22, 2024 18:22
jdubpark
force-pushed
the
jdub/emit-more-params-in-stake-events
branch
from
August 23, 2024 01:52
174130c
to
cc47376
Compare
jdubpark
changed the title
feat(contracts): add event params & explicit cmp/uncmp names
feat(contracts): add event params and define explicit cmp and uncmp names
Aug 23, 2024
ezreal1997
requested changes
Aug 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix ci failure
jdubpark
force-pushed
the
jdub/emit-more-params-in-stake-events
branch
from
August 23, 2024 15:19
4958408
to
38adac1
Compare
jdubpark
changed the title
feat(contracts): add event params and define explicit cmp and uncmp names
feat(contracts): add event params & make explicit un/cmp names
Aug 23, 2024
ezreal1997
approved these changes
Aug 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add event params and define explicit cmp and uncmp names
issue: closes #23