Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contracts): add event params & make explicit un/cmp names #11

Merged
merged 8 commits into from
Aug 23, 2024

Conversation

jdubpark
Copy link
Contributor

@jdubpark jdubpark commented Aug 22, 2024

add event params and define explicit cmp and uncmp names

issue: closes #23

@jdubpark jdubpark force-pushed the jdub/emit-more-params-in-stake-events branch 2 times, most recently from c60c783 to c5c2af7 Compare August 22, 2024 18:21
@jdubpark jdubpark marked this pull request as ready for review August 22, 2024 18:22
@jdubpark jdubpark closed this Aug 22, 2024
@jdubpark jdubpark reopened this Aug 23, 2024
@jdubpark jdubpark force-pushed the jdub/emit-more-params-in-stake-events branch from 174130c to cc47376 Compare August 23, 2024 01:52
@jdubpark jdubpark changed the title feat(contracts): add event params & explicit cmp/uncmp names feat(contracts): add event params and define explicit cmp and uncmp names Aug 23, 2024
Copy link
Contributor

@ezreal1997 ezreal1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix ci failure

@jdubpark jdubpark force-pushed the jdub/emit-more-params-in-stake-events branch from 4958408 to 38adac1 Compare August 23, 2024 15:19
@jdubpark jdubpark changed the title feat(contracts): add event params and define explicit cmp and uncmp names feat(contracts): add event params & make explicit un/cmp names Aug 23, 2024
@jdubpark jdubpark requested a review from ezreal1997 August 23, 2024 15:27
Copy link
Contributor

@ezreal1997 ezreal1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdubpark jdubpark merged commit 7aedb43 into main Aug 23, 2024
6 of 8 checks passed
@AndyBoWu AndyBoWu deleted the jdub/emit-more-params-in-stake-events branch September 19, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emit uncompressed keys in Staking contract events
2 participants