Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Charge fees on unsetOperator and remove operator arg from unsetOperator CLI #438

Closed
0xHansLee opened this issue Dec 14, 2024 · 0 comments
Closed

Charge fees on unsetOperator and remove operator arg from unsetOperator CLI #438

0xHansLee opened this issue Dec 14, 2024 · 0 comments
Assignees
@0xHansLee
Labels
bug Something isn't working

Comments

@0xHansLee
Copy link
Contributor

Description and context

Currently, no fees are charged when user unset the operator. Need to charge fees to prevent spam on EL.
In addition, an argument for unsetOperator CLI need to be changed according to this change (#358).

Suggested solution

chargeFee modifier should be added to unsetOperator in IPTokenStaking contract.
And remove operator argument from unsetOperator CLI.
@0xHansLee 0xHansLee added the bug Something isn't working label Dec 14, 2024
@0xHansLee 0xHansLee self-assigned this Dec 14, 2024
@0xHansLee 0xHansLee mentioned this issue Dec 14, 2024
Merged
0xHansLee added a commit that referenced this issue Dec 17, 2024
@0xHansLee
feat(contract): charge fees on unsetting operator (#439)
528fecd 
Charge fees on `unsetOperator` and made changes for CLI to be compatible
with this change.

issue: #438
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xHansLee 0xHansLee

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@0xHansLee