Skip to content
This repository has been archived by the owner on Apr 5, 2023. It is now read-only.

Eh main/feature/consumer #18

Merged
merged 112 commits into from
May 4, 2022
Merged

Eh main/feature/consumer #18

merged 112 commits into from
May 4, 2022

Conversation

eHattori
Copy link
Contributor

✨ New Feature

The consumer with an include in class and with a method that process payload from the message:

class TestWorker
  include PipefyMessage::Worker
  pipefymessage_options broker: "aws", queue_name: "pipefy-local-queue"

  def perform(message)
    puts message
  end
end

Create abstraction to implement any broker

Refactor

Refactor Publisher to the same model of the consumer

PipefyMessage::Publisher.new.publish({ "teste": "teste"}, "pipefy-local-topic")

🗂 Related cards

[Async] Create Consumer Abstraction that receive the method

eHattori and others added 30 commits April 11, 2022 13:30
Co-authored-by: Duda Ferreira <[email protected]>
Co-authored-by: Duda Ferreira <[email protected]>
Really just manual tests at this point, but I figured I should have some
Copy link
Collaborator

@looslidias looslidias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work here.

BTW, really liked to have those comments for doubts and some decision making.

IMHO, let's move forward within these changes and keep improving through some risk mapping and also needs from other teams

@jleber jleber marked this pull request as ready for review May 4, 2022 19:49
@eHattori eHattori merged commit a30e740 into main May 4, 2022
@eHattori eHattori deleted the eh-main/feature/consumer branch May 4, 2022 21:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants