This repository has been archived by the owner on Apr 5, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Duda Ferreira <[email protected]>
Co-authored-by: Duda Ferreira <[email protected]>
Really just manual tests at this point, but I figured I should have some
looslidias
reviewed
Apr 29, 2022
looslidias
approved these changes
Apr 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work here.
BTW, really liked to have those comments for doubts and some decision making.
IMHO, let's move forward within these changes and keep improving through some risk mapping and also needs from other teams
Sorry, this was my first time involved in a PR, I'd forgotten to keep track of the comments hahaha That's why I didn't do this earlier, thanks for your great reviews! :D
We can always add abstractions once we have more brokers, but I don't think there was enough shared behavior between classes to justify having that "interface" now
Ef/refactor/remove-inheritance
jleber
approved these changes
May 4, 2022
ferreira-mev
reviewed
May 4, 2022
ferreira-mev
reviewed
May 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ New Feature
The consumer with an
include
in class and with a method that process payload from the message:Create abstraction to implement any
broker
Refactor
Refactor Publisher to the same model of the consumer
🗂 Related cards
[Async] Create Consumer Abstraction that receive the method