Merge pull request #3 from pipefy/bm-fix-empty-address

Fix the name extraction when empty strings are provided

.ruby-version

@@ -1 +1 @@
-2.2.2
+2.4.1

.travis.yml

@@ -3,6 +3,7 @@ rvm:
   - 2.0
   - 2.1
   - 2.2
+  - 2.4
 env:
   - "RAILS_BRANCH=4-1-stable"
   - "RAILS_BRANCH=4-2-stable"

griddler.gemspec

@@ -10,11 +10,11 @@ Gem::Specification.new do |s|
   s.homepage    = 'http://thoughtbot.com'
   s.summary     = 'SendGrid Parse API client Rails Engine'
 
-  s.required_ruby_version = Gem::Requirement.new(">= 1.9.2")
+  s.required_ruby_version = Gem::Requirement.new(">= 2.4.1")
   s.files = Dir['{app,config,lib}/**/*'] + ['LICENSE', 'Rakefile', 'README.md']
   s.require_paths = %w{app lib}
 
-  s.add_dependency 'rails', '>= 3.2.0'
+  s.add_dependency 'rails', '>= 4.2.0'
   s.add_dependency 'htmlentities'
   s.add_development_dependency 'rspec-rails'
   s.add_development_dependency 'sqlite3'

lib/griddler/email_parser.rb

@@ -65,7 +65,7 @@ def self.extract_email_address(full_address)
 
   def self.extract_name(full_address)
     full_address = full_address.strip
-    name = full_address.split('<').first.strip
+    name = full_address.split('<').first&.strip
     if name.present? && name != full_address
       name
     end

spec/griddler/email_spec.rb

@@ -582,6 +582,23 @@ def header_from_email(header)
 
   end
 
+  it 'handles empty names' do
+    email = Griddler::Email.new(
+      text: 'hi',
+      to: [' '],
+      from: @full_address
+    )
+    expected = {
+      token: nil,
+      host: nil,
+      email: '',
+      full: ' ',
+      name: nil
+    }
+    expect(email.to).to eq [expected]
+    expect(email.from).to eq @address_components
+  end
+
   it 'returns the BCC email' do
     email = Griddler::Email.new(
         text: 'hi',