Add new type: ValuesType
#99
Conversation
feat(utility-types): Add `ValuesType`. Proposed in piotrwitek#75.
There was a problem hiding this comment.
Hey @Axure,
Thanks for PR, ValuesType in mapped-types looks good, but could you please remove $ValuesType from utility-types, it was not requested to be added and shouldn't be there. Thanks!
src/mapped-types.ts
Outdated
| @@ -576,3 +576,41 @@ export type Optional<T extends object, K extends keyof T = keyof T> = Omit< | |||
| K | |||
| > & | |||
| Partial<Pick<T, K>>; | |||
|
|
|||
| /** | |||
| * $ValuesType | |||
There was a problem hiding this comment.
Should be ValuesType, without $
There was a problem hiding this comment.
Oops I forgot to change the examples when I copied it from the $ValuesType I wrote at first.
I've removed that $.
| @@ -501,3 +502,28 @@ type RequiredOptionalProps = { | |||
| // @dts-jest:pass:snap -> Optional<Props, "age" | "visible"> | |||
| testType<Optional<Props, 'age' | 'visible'>>({ name: 'Yolo', age: 99 }); | |||
| } | |||
|
|
|||
| @@ -586,6 +587,34 @@ type ExtendedProps = Assign<Props, NewProps>; | |||
|
|
|||
| [⇧ back to top](#table-of-contents) | |||
|
|
|||
| ### `ValuesType<T>` | |||
src/utility-types.ts
Outdated
| @@ -24,6 +24,25 @@ export type $Keys<T extends object> = keyof T; | |||
| */ | |||
| export type $Values<T extends object> = T[keyof T]; | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
All related $ValuesType code and tests should be removed
|
@Axure great job, thx! There is a IssueHunt bounty, please submit your PR: https://issuehunt.io/r/piotrwitek/utility-types/issues/75 |
Done. |
Description
Add new type:
ValuesTypeRelated issues:
Checklist
For new features:
dts-jestIssueHunt Summary
Referenced issues
This pull request has been submitted to:
IssueHunt has been backed by the following sponsors. Become a sponsor