Add bigint to the primitive type #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 23, 2019 12:53
…k to mdn 'typeof'
…10, using tooling from this package)
piotrwitek
requested changes
Jun 23, 2019
piotrwitek
approved these changes
Jun 23, 2019
|
Great job, thanks for contribution @9SMTM6 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added bigint to the
Primitivetype.I've tested an import of the
Primitivetype with bigint into an project using TS 3.1.6 with default settings, and it worked - of course it didnt recognize bigint, but no syntax error on usage on other variables and it didnt break support for the other types. Thus I'm not creating another version of this package for this. But bigint support was only added in TS 3.2, which is below the required v3.1 you ask for for v3.X of this package, so make some more tests (i.e. with different tsconfig settings) at your own discretion.Also I didnt even increase the minor version as I couldnt find any documentation on whether I should.
Note: I had to change the syntax of the node scripts slightly to make them work on my PC. The changes are in a single commit you can revert if thats an issue for you.
Also the type tests dont really seem to do much at all... In one of my experiments I have tried
tsdand it worked so far, if that doesnt make too many problems with integration in the pipeline, you might want to check it out.Related issues:
Checklist