perf: reduce .filter

pionxzh · Aug 12, 2023 · ed24762 · ed24762
1 parent 40702d5
commit ed24762
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 9 deletions.
diff --git a/packages/unminify/src/transformations/__tests__/un-sequence-expression.spec.ts b/packages/unminify/src/transformations/__tests__/un-sequence-expression.spec.ts
@@ -16,9 +16,16 @@ c();
 
 inlineTest('split return sequence expression',
   `
+if(a) return b(), c();
+
 return a(), b(), c()
 `,
   `
+if (a) {
+  b();
+  return c();
+}
+
 a();
 b();
 return c();
@@ -125,11 +132,13 @@ try {
 
 inlineTest('split throw sequence expression',
 `
-throw a(), b()
+if(e !== null) throw a(), e
 `,
 `
-a();
-throw b();
+if (e !== null) {
+  a();
+  throw e;
+}
 `,
 )
 

diff --git a/packages/unminify/src/transformations/function-to-arrow.ts b/packages/unminify/src/transformations/function-to-arrow.ts
@@ -13,13 +13,13 @@ export const transformAST: ASTTransformation = (context) => {
 
     root
         .find(j.FunctionDeclaration)
-        .filter((path) => {
-            if (j.MethodDefinition.check(path.parent)) return false
-            if (j.Property.check(path.parent)) return false
-            if (containsThisExpression(path.node)) return false
-            return true
-        })
         .forEach((path) => {
+            if (j.MethodDefinition.check(path.parent.node)) return
+            if (j.Property.check(path.parent.node)) return
+            if (j.ExportDeclaration.check(path.parentPath.node)) return
+            if (j.ExportDefaultDeclaration.check(path.parent.node)) return
+            if (containsThisExpression(path.node)) return
+
             const { node } = path
             const { id } = node
             if (!id) return