fix: replace require.d without checking exports

pionxzh · Aug 5, 2023 · ebee03b · ebee03b
1 parent 448595d
commit ebee03b
Showing 1 changed file with 19 additions and 1 deletion.
diff --git a/packages/unpacker/src/extractors/webpack4.ts b/packages/unpacker/src/extractors/webpack4.ts
@@ -89,7 +89,25 @@ function convertRequireHelpers(j: JSCodeshift, collection: Collection<any>) {
         },
         arguments: [{
             type: 'Identifier' as const,
-            name: 'exports' as const,
+            /**
+             * The first argument is the exports object
+             * But it's not always called `exports`
+             * The common case is this `exports` object
+             * is come from the function parameter
+             * ```js
+             * function(module, exports, require) {
+             *   require.d(exports, key, function() { return moduleContent })
+             * }
+             * ```
+             *
+             * But another case is this `exports` object
+             * is just an object created in the module
+             * ```js
+             * var exports = {}
+             * require.d(exports, key, function() { return moduleContent })
+             * ```
+             */
+            // name: 'exports' as const,
         }, {
             type: 'Literal' as const,
         }, {