refactor

pionas · Dec 18, 2023 · 7f9d761 · 7f9d761
1 parent ff736fc
commit 7f9d761
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 27 deletions.
diff --git a/src/main/java/info/pionas/quiz/domain/exam/ExamServiceImpl.java b/src/main/java/info/pionas/quiz/domain/exam/ExamServiceImpl.java
@@ -61,11 +61,9 @@ private List<NewExamAnswer> getExamAnswers(UUID resultId, List<PassExamAnswer> a
     }
 
     private NewExamAnswer prepareNewExamAnswer(UUID resultId, PassExamAnswer answer, LocalDateTime dateTime) {
-        if (quizAnswerRepository.isCorrectAnswer(answer.getQuestionId(), answer.getAnswerId())) {
-            return NewExamAnswer.correct(resultId, dateTime, answer.getQuestionId(), answer.getAnswerId());
-        } else {
-            return NewExamAnswer.wrong(resultId, dateTime, answer.getQuestionId(), answer.getAnswerId());
-        }
+        final var correctAnswer = quizAnswerRepository.isCorrectAnswer(answer.getQuestionId(), answer.getAnswerId());
+        return new NewExamAnswer(resultId, answer.getQuestionId(), answer.getAnswerId(), correctAnswer, dateTime);
+
     }
 
 }
diff --git a/src/main/java/info/pionas/quiz/domain/exam/api/NewExamAnswer.java b/src/main/java/info/pionas/quiz/domain/exam/api/NewExamAnswer.java
@@ -1,38 +1,18 @@
 package info.pionas.quiz.domain.exam.api;
 
-import lombok.Builder;
+import lombok.AllArgsConstructor;
 import lombok.Getter;
 
 import java.time.LocalDateTime;
 import java.util.UUID;
 
-@Builder
 @Getter
+@AllArgsConstructor
 public class NewExamAnswer {
 
     private UUID resultId;
     private UUID questionId;
     private UUID answerId;
     private Boolean correct;
     private LocalDateTime created;
-
-    public static NewExamAnswer correct(UUID resultId, LocalDateTime dateTime, UUID questionId, UUID answerId) {
-        return NewExamAnswer.builder()
-                .resultId(resultId)
-                .questionId(questionId)
-                .answerId(answerId)
-                .correct(true)
-                .created(dateTime)
-                .build();
-    }
-
-    public static NewExamAnswer wrong(UUID resultId, LocalDateTime dateTime, UUID questionId, UUID answerId) {
-        return NewExamAnswer.builder()
-                .resultId(resultId)
-                .questionId(questionId)
-                .answerId(answerId)
-                .correct(false)
-                .created(dateTime)
-                .build();
-    }
 }