Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SCTPTransportStats #2112

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Conversation

wawesomeNOGUI
Copy link
Member

Description

Adds functions to get SCTPTransport stats defined in https://www.w3.org/TR/webrtc-stats/#dom-rtcsctptransportstats. This PR is in conjunction with pion/sctp#205.

@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Patch coverage: 40.00% and project coverage change: -0.07% ⚠️

Comparison is base (cf5dbbe) 77.15% compared to head (0ce283d) 77.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2112      +/-   ##
==========================================
- Coverage   77.15%   77.09%   -0.07%     
==========================================
  Files          87       87              
  Lines        9674     9687      +13     
==========================================
+ Hits         7464     7468       +4     
- Misses       1752     1761       +9     
  Partials      458      458              
Flag Coverage Δ
go 78.73% <40.00%> (-0.08%) ⬇️
wasm 64.35% <0.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
stats.go 62.57% <0.00%> (-1.78%) ⬇️
sctptransport.go 77.49% <100.00%> (+0.33%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wawesomeNOGUI wawesomeNOGUI marked this pull request as draft February 2, 2023 16:18
@Sean-Der
Copy link
Member

I am sorry this didn't get merged sooner @wawesomeNOGUI this is a good change.

I am gonna fix up and merge now.

@wawesomeNOGUI
Copy link
Member Author

@Sean-Der No worries! Sorry I uploaded all those commits in such a messy way:P

@Sean-Der Sean-Der marked this pull request as ready for review August 19, 2023 19:16
Sean-Der added a commit to pion/sctp that referenced this pull request Aug 21, 2023
@Sean-Der Sean-Der merged commit ee483da into pion:master Aug 21, 2023
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants