Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no ssrc-group:FID in sdp text #1989

Closed
smaznet opened this issue Oct 21, 2021 · 5 comments · Fixed by #2914
Closed

no ssrc-group:FID in sdp text #1989

smaznet opened this issue Oct 21, 2021 · 5 comments · Fixed by #2914

Comments

@smaznet
Copy link

smaznet commented Oct 21, 2021

Your environment.

  • Version: Release
  • Other Information - stacktraces, related issues, suggestions how to fix, links for us to have context

What did you do?

I used this code to generate a sdp for telegram

	opts := webrtc.OfferOptions{
		OfferAnswerOptions: webrtc.OfferAnswerOptions{VoiceActivityDetection: false},
		ICERestart:         false,
	}

	offerl, _ := peerConnection.CreateOffer(&opts)
	if err = peerConnection.SetLocalDescription(offerl); err != nil {
		panic(err)
	}

	gatherComplete := webrtc.GatheringCompletePromise(peerConnection)

	<-gatherComplete
	sdpRes := peerConnection.LocalDescription().SDP

and i also used node-wrtc module in nodejs to generate sdp using this code

   const offer = await this.#connection!.createOffer({
      offerToReceiveVideo: true,
      offerToReceiveAudio: true,
    });
    await this.#connection!.setLocalDescription(offer);

What did you expect?

in output there should be a tag with this prefix a=ssrc-group:FID which is required for telegram(i think)

What happened?

in nodejs version that field exists in sdp and everything is okay while in go version there is no such field in sdp

And also a question

why in go version CreateOffer this options not exists?

      offerToReceiveVideo: true,
      offerToReceiveAudio: true,
@smaznet
Copy link
Author

smaznet commented Oct 21, 2021

i also tested https://github.com/devopvoid/webrtc-java and it works fine

@Sean-Der
Copy link
Member

Sean-Der commented Nov 5, 2021

Hey @smaznet sorry for the delay!

If you add a a=ssrc-group:FID to the SDP manually does it work? We don't send RTX with a distinct SSRC so we don't have a SSRC group. I would trying just defining one with the second SSRC being a random value.

offerToReceiveVideo and offerToReceiveAudio aren't valid parameters. I would be careful using a WebRTC implementation that still recommends them, it may still be Plan-B. If you want to receive audio + video I would create recvonly transceivers.

pc.addTransceiver('video', {direction: 'recvonly'})
pc.addTransceiver('audio', {direction: 'recvonly'})

@smaznet
Copy link
Author

smaznet commented Nov 5, 2021

Hi @Sean-Der thanks for responding

No i tested it by putting ssrc-group manually but it doesn't work

actually i debuged with telegram logs seems packets doesn't sent to telegram

@Sean-Der
Copy link
Member

Sean-Der commented Nov 6, 2021

@smaznet Is there a way I could test/debug this myself? I have some time and would love to try myself.

@smaznet
Copy link
Author

smaznet commented Nov 6, 2021

@smaznet Is there a way I could test/debug this myself? I have some time and would love to try myself.

Yes sure
Message me on telegram: @UnrealMosi

@Sean-Der Sean-Der added this to the 3.2.0 milestone Jan 23, 2022
@Sean-Der Sean-Der removed this from the 3.2.0 milestone May 22, 2022
Sean-Der added a commit that referenced this issue Oct 4, 2024
If the MediaEngine contains support for them a SSRC will be generated
appropriately

Co-authored-by: aggresss <[email protected]>
Co-authored-by: Kevin Wang <[email protected]>

Resolves #1989
Resolves #1675
Sean-Der added a commit that referenced this issue Oct 4, 2024
If the MediaEngine contains support for them a SSRC will be generated
appropriately

Co-authored-by: aggresss <[email protected]>
Co-authored-by: Kevin Wang <[email protected]>

Resolves #1989
Resolves #1675
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants