Update Docker tests #166
Open
Update Docker tests #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test in pion/ci-sandbox#89 |
stv0g
force-pushed
the
more-platforms
branch
20 times, most recently
from
8eebdeb
to
a2f2d93
Compare
at-wat
reviewed
Apr 27, 2023
There was a problem hiding this comment.
Seems that the changes in this PR is not actually tested in pion/ci-sandbox#89
(Reusable workflow in the master branch is used and arch input is ignored)
|
Oh sorry. They are now tested. However, I am still not completely confident that this is a good change due to its performance implications. Emulating the ARM builds and test execution can be rather slow, and likely break/timeout test cases.. I am also looking into using Vagrant for testing other OSes like BSDs.. |
at-wat
reviewed
May 8, 2023
|
@stv0g I think it's better to test it on some large repos, which take long CI time, to check CI performance impact |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've reworked how we run tests. With this PR I propose to use the same workflow for running all our tests (excluding WASM) via Docker.
This allows us to easily also test Pion on non-x86 platforms via QEmu Userspace Emulation.
Currently, we are emulating both the test compilation and execution. I am tempted to put in some more effort to do actual cross-compilation and use QEmu only for the test execution.
However, this is a bit tricky as we need to compile & execute a dedicated test executable for each package.
Which is a bit of an issue as we also need to gather coverage information alongside..