Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve docker workflow for local development #1478

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Improve docker workflow for local development #1478

merged 1 commit into from
Mar 1, 2024

Conversation

tylerwowen
Copy link
Contributor

@tylerwowen tylerwowen commented Mar 1, 2024 •
edited
Loading

Improvements

  1. Ignore target directory so they are not copied blindly.
  2. Add build cache so maven dependencies will not be downloaded every time.
  3. No more assembly step in the build, so there is no zip and unzip.
  4. Use a script run.sh that actually exists in the repo.

@tylerwowen tylerwowen requested a review from a team as a code owner March 1, 2024 02:11
This was referenced Mar 1, 2024
Merged
Merged
@github-actions github-actions bot added the deploy-service Includes changes to deploy-service label Mar 1, 2024
@tylerwowen tylerwowen requested a review from osoriano March 1, 2024 17:36
osoriano
osoriano previously approved these changes Mar 1, 2024
View reviewed changes
Base automatically changed from spr/master/1ff7710b to master March 1, 2024 21:49
@tylerwowen tylerwowen dismissed osoriano’s stale review March 1, 2024 21:49

The base branch was changed.

@tylerwowen tylerwowen requested a review from osoriano March 1, 2024 21:50
osoriano
osoriano previously approved these changes Mar 1, 2024
View reviewed changes
@tylerwowen tylerwowen merged commit 9d7f0b5 into master Mar 1, 2024
5 checks passed
@tylerwowen tylerwowen deleted the spr/master/7b820d46 branch March 1, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osoriano osoriano osoriano approved these changes

Assignees
No one assigned
Labels
deploy-service Includes changes to deploy-service
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tylerwowen @osoriano