Send null messages to kafka avro deserializer #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Secor community!
We are using Secor for Avro messages with tombstone messaging - meaning we have null values in kafka (for more information: https://debezium.io/blog/tags/smt/#delete_records).
kafka-avro-serializer handles null as payload, so no problem there. The problem we are facing is that Secor converts null values into an empty byte array. In such cases, kafka-avro-serializer is trying to deserialize the data and we get "Error deserializing Avro message" as it is an empty byte array.
We fixed this issue by passing a null value to the serializer, and we now use the serializer results only if they are not null.
We would sincerely appreciate your assistance with this.