JSON array of object saved as ORC format #1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like the travis build is failing for this PR: https://travis-ci.org/github/pinterest/secor/builds/683900104 The error doesn't seem related to your PR, and probably a transient error. Can you do a dummy checkin (e.g adding a comment in the code) to trigger the rebuild? |
|
Great, I will merge the PR, thanks. |
|
No problem, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
In some situations Kafka messages may contains JSON array of objects. Each item on the list have the same schema. This patch allows to read messages like this and save each list item as a separate records.
This patch should not have performance implications as root JSON element type was checked before.
It was expected to receive JsonObject but in our scenario it is JsonArray.