Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace notification with toast #369

Merged
merged 4 commits into from
Jan 6, 2021
Merged

Replace notification with toast #369

merged 4 commits into from
Jan 6, 2021

Conversation

czgu
Copy link
Collaborator

@czgu czgu commented Jan 6, 2021 •
edited
Loading

  • Removed notifications & react-spring animations for simplification
  • Remove animation for the progress bar and simplified animation for popover
  • Use react-hot-toast for better handling of notifications with promises
  • Added storybook for Toast and Popover
  • Added theme selection for storybook
  • Refactored templated query rendering and with better error messages on a syntax error

@czgu czgu added the enhancement New feature or request label Jan 6, 2021
@czgu czgu requested a review from meowcodes January 6, 2021 17:54
@czgu czgu merged commit d92d94e into master Jan 6, 2021
@czgu czgu deleted the toast branch January 6, 2021 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meowcodes meowcodes meowcodes approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@czgu @meowcodes