Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: survey for table modal is blinking #1396

Merged
merged 2 commits into from
Feb 14, 2024
Merged

fix: survey for table modal is blinking #1396

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4521f49
fix: survey for table modal is blinking
czgu Jan 18, 2024
d2c7abf
self review
czgu Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion querybook/webapp/hooks/ui/useSurveyTrigger.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import {
saveSurveyTriggerRecord,
shouldTriggerSurvey,
} from 'lib/survey/triggerLogic';
import { useDebouncedFn } from 'hooks/useDebouncedFn';

export async function triggerSurvey(
surface: SurveySurfaceType,
Expand Down Expand Up @@ -37,7 +38,7 @@ export async function triggerSurvey(
export function useSurveyTrigger(endSurveyOnUnmount: boolean = false) {
const toastId = useRef<string | null>(null);

const triggerSurveyHook = React.useCallback(
const triggerSurveyHook = useDebouncedFn(
(surface: SurveySurfaceType, surfaceMeta: Record<string, any>) => {
if (toastId.current) {
toast.dismiss(toastId.current);
Expand All @@ -50,6 +51,7 @@ export function useSurveyTrigger(endSurveyOnUnmount: boolean = false) {
}
);
},
500,
[]
);

Expand Down
Loading