fix: add post processing to ai generated content #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jczhong84
commented
Jun 30, 2023
jczhong84
commented
- trim the quotes/trailing period from the query title
- trim the ``` from the sql
- fix the diff view's width issue: it will go beyond 100% of the container
czgu
reviewed
Jun 30, 2023
| @@ -57,10 +59,11 @@ export const QueryComparison: React.FC<{ | |||
| return [added, removed]; | |||
| }, [fromQuery, toQuery, disableHighlight, hideEmptyQuery]); | |||
|
|
|||
| const width = hasHiddenQuery ? '100%' : 'calc(50% - 4px)'; | |||
There was a problem hiding this comment.
use css with sibling selector? this is kind of hacky js+css solution
czgu
approved these changes
Jun 30, 2023
aidenprice
pushed a commit
to arrowtail-precision/querybook
that referenced
this pull request
Jan 3, 2024
* fix: add post processing to ai generated content * comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.