feat: add LLM powered text2sql support #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czgu
reviewed
Jun 23, 2023
|
|
||
| @register("/ai/generate_query/", custom_response=True) | ||
| def generate_sql_query( | ||
| query_engine_id: int, tables: list[str], question: str, data_cell_id: int = None |
There was a problem hiding this comment.
instead of data cell, use original_query so it is not limited to data doc?
There was a problem hiding this comment.
The problem is I realized that for GET http request, it has length limit on the query string. So it may not be safe to pass along the whole query.
Can reconsider the EventSource solution in future and change it back to use POST method. For this specific case, I can move the get query from the data cell into this api endpoint and make ai_assistant to accept the original query.
querybook/webapp/components/AIAssistant/QueryGenerationModal.tsx
Outdated
Show resolved
Hide resolved
querybook/webapp/components/AIAssistant/QueryGenerationModal.tsx
Outdated
Show resolved
Hide resolved
querybook/webapp/components/AIAssistant/QueryGenerationModal.tsx
Outdated
Show resolved
Hide resolved
czgu
approved these changes
Jun 23, 2023
aidenprice
pushed a commit
to arrowtail-precision/querybook
that referenced
this pull request
Jan 3, 2024
* feat: add LLM powered text2sql support * comments * comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
text2sql.mp4