Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: IO Exception on closed file #1237

Merged
merged 7 commits into from May 13, 2023
Merged

Fix: IO Exception on closed file #1237

merged 7 commits into from May 13, 2023

Conversation

ghost
Copy link

@ghost ghost commented Apr 26, 2023

No description provided.

@ghost
Copy link
Author

ghost commented Apr 26, 2023

About this PR:

While running a query. with RESULT_STORE_TYPE as file, the execution completes but shows below error while displaying result.

I/O exception opening closed file

Screenshot 2023-04-26 at 12 26 31 PM

So as a fix, created a PR.

@ghost
Copy link
Author

ghost commented May 2, 2023

Hi @jczhong84,
Can you please have a look at this PR too?

@jczhong84
Copy link
Collaborator

Thanks for the fix!

please fix the lint errors

@ghost ghost requested a review from jczhong84 May 4, 2023 13:24
@jczhong84
Copy link
Collaborator

@najma-kunju there is still lint failure

@ghost
Copy link
Author

ghost commented May 10, 2023

@jczhong84, have fixed the current lint error

@jczhong84 jczhong84 merged commit dada0e9 into pinterest:master May 13, 2023
aidenprice pushed a commit to arrowtail-precision/querybook that referenced this pull request Jan 3, 2024
* filestore performance fix

* fix for I/O exception opening closed file

* remove comments

* lint errors

* lint error fix

* lint fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants