fix: EntitySelect #1215
Merged
fix: EntitySelect #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czgu
reviewed
Apr 6, 2023
| @@ -64,8 +67,8 @@ export const EntitySelect = ({ | |||
| () => | |||
| !searchText || | |||
| (!selectedEntities.includes(searchText) && | |||
| validateEntity(searchText)), | |||
| [searchText, selectedEntities, validateEntity] | |||
| (!creatable || !validateEntity || validateEntity(searchText))), | |||
There was a problem hiding this comment.
this is kind of hard to read:
const isValidForCreation = creatable && searchText.length > 0 && !selectedEntities.includes(searchText) && (
validateEntity?.(searchText) ?? true
)
| @@ -20,7 +20,10 @@ interface IEntitySelectProps { | |||
| placeholder?: string; | |||
| onSelect?: (entity: string) => void; | |||
| onEntitiesChange?: (entities: string[]) => void; | |||
|
|
|||
| // will validate only if creatable is true | |||
There was a problem hiding this comment.
change this to
/**
*
*/
format so it can be include in jsdocs
czgu
reviewed
Apr 6, 2023
| @@ -104,7 +107,7 @@ export const EntitySelect = ({ | |||
| ))} | |||
| </div> | |||
| )} | |||
| <div className={isValid ? undefined : 'invalid'}> | |||
| <div className={isInvalidForCreation ? 'invalid' : 'undefined'}> | |||
There was a problem hiding this comment.
there is a quote in undefined
czgu
approved these changes
Apr 6, 2023
rohan-sh1
pushed a commit
to CAI-TECHNOLOGIES/cai-ext-db-explorer
that referenced
this pull request
Apr 11, 2023
* fix: EntitySelect * check creatable * comments * comments * fix undefined
aidenprice
pushed a commit
to arrowtail-precision/querybook
that referenced
this pull request
Jan 3, 2024
* fix: EntitySelect * check creatable * comments * comments * fix undefined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
forgot to check
validateEntitycould be null