feat: support for a general validation message in query editor #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
title needs formatting
suryabhaskarkarri
changed the title
github-actions
bot
removed
the
title needs formatting
suryabhaskarkarri
force-pushed
the
query-validation-type-change
branch
3 times, most recently
from
3308a0f
to
e920af5
Compare
|
UI screenshots on how the message would look like
|
czgu
reviewed
Feb 10, 2023
| @@ -15,18 +20,21 @@ class QueryValidationSeverity(Enum): | |||
| class QueryValidationResult(object): | |||
| def __init__( | |||
| self, | |||
| obj_type: QueryValidationResultObjectType, | |||
There was a problem hiding this comment.
can you make this optional and default to QueryValidationResultObjectType.LINT? this makes sure other plugin still works as is
jczhong84
reviewed
Feb 10, 2023
suryabhaskarkarri
force-pushed
the
query-validation-type-change
branch
from
e920af5
to
b84d7b4
Compare
|
@suryabhaskarkarri @jczhong84 what is your thought of calling the types |
suryabhaskarkarri
force-pushed
the
query-validation-type-change
branch
from
b84d7b4
to
3c721f6
Compare
|
@czgu I feel LINT is more meaningful & understandable. |
czgu
approved these changes
Feb 10, 2023
rohan-sh1
pushed a commit
to CAI-TECHNOLOGIES/cai-ext-db-explorer
that referenced
this pull request
Apr 11, 2023
…rest#1156) * feat: support for general message in query validation plugin * addressed review comments
aidenprice
pushed a commit
to arrowtail-precision/querybook
that referenced
this pull request
Jan 3, 2024
…rest#1156) * feat: support for general message in query validation plugin * addressed review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.