feat: add user group db schema support #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jczhong84
commented
Feb 4, 2023
jczhong84
commented
- update db schema to support user group
- add a new component to display user group info
jczhong84
force-pushed
the
feat/usergroup
branch
from
66bd8f0
to
550b416
Compare
jczhong84
force-pushed
the
feat/usergroup
branch
from
550b416
to
8e89c07
Compare
czgu
reviewed
Feb 4, 2023
| Group members | ||
| </AccentText> | ||
| <div className="members-container"> | ||
| {members.map((m) => ( |
There was a problem hiding this comment.
put a limit on how many member to show
There was a problem hiding this comment.
should we provide "show more" to allow them to view all the members?
|
@jczhong84 there is another concern that i just realized. With this change, users will be able to add "groups" as editors of datadocs. For now, can you disable groups being indexed into elasticsearch? |
czgu
reviewed
Feb 7, 2023
|
|
||
|
|
||
| ## Load Users and Group | ||
| If you're not using the default username/password authentication, you probably need to sync the users/groups regularly from your organization's sysmtem into Querybook. To do this, you can |
There was a problem hiding this comment.
oauth/ldap auth both supports auto-creation of users. I guess you can mention groups can only be sync'ed now and cannot be created in UI
| A user or a group can have below properties | ||
| - username: It is the unique iendifiter of a user or a group. | ||
| - fullname: Full name or display name of a user or a group | ||
| - password: Password of a user. Only applies to a user. |
There was a problem hiding this comment.
Only applies to users when using default user/password auth
| - fullname: Full name or display name of a user or a group | ||
| - password: Password of a user. Only applies to a user. | ||
| - email: Email of a user or a group. | ||
| - profile_img: Profile image of a user or a group. |
querybook/webapp/const/uiConfig.ts
Outdated
| * this constant controls the maximum number | ||
| * of members to show in the user group popover | ||
| */ | ||
| export const MAX_USER_GROUP_MEMBERS_TO_SHOW = 1; |
querybook/webapp/const/user.ts
Outdated
|
|
||
| roles?: number[]; | ||
|
|
||
| // Properties below are only available when is_group is true | ||
| properties?: { |
There was a problem hiding this comment.
properties is no longer optional
| We use the `User` model to represent a user or a group. | ||
|
|
||
| A user or a group can have below properties | ||
| - username: It is the unique iendifiter of a user or a group. |
czgu
previously approved these changes
Feb 7, 2023
| ## Create/Load Users and Group | ||
| For users | ||
| - default user/password authentication: people can sign up as a new user on UI. | ||
| - auth/ldap authentication: they both support auto-creation of users. |
czgu
approved these changes
Feb 7, 2023
rohan-sh1
pushed a commit
to CAI-TECHNOLOGIES/cai-ext-db-explorer
that referenced
this pull request
Apr 11, 2023
* feat: add user group db schema support * comments * disable user group indexing * addto sidebar * fix linter * more comments * fix linter * typo
aidenprice
pushed a commit
to arrowtail-precision/querybook
that referenced
this pull request
Jan 3, 2024
* feat: add user group db schema support * comments * disable user group indexing * addto sidebar * fix linter * more comments * fix linter * typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.