Add some frontend view/click events #1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czgu
previously approved these changes
Jan 6, 2023
czgu
reviewed
Jan 6, 2023
| @@ -112,6 +112,18 @@ export const SearchOverview: React.FC<ISearchOverviewProps> = ({ | |||
| const results = resultByPage[currentPage] || []; | |||
| const isLoading = !!searchRequest; | |||
|
|
|||
| // Log search results | |||
| useEffect(() => { | |||
| if (!isLoading && !!searchString.length && !!results.length) { | |||
There was a problem hiding this comment.
can you use searchString.length > 0 and results.length >0, seems easier to understand than !!
czgu
approved these changes
Jan 6, 2023
rohan-sh1
pushed a commit
to CAI-TECHNOLOGIES/cai-ext-db-explorer
that referenced
this pull request
Feb 28, 2023
* Add frontend event logging * add some view events * fix one element type * refactor * add search resutls view events * comment
aidenprice
pushed a commit
to arrowtail-precision/querybook
that referenced
this pull request
Jan 3, 2024
* Add frontend event logging * add some view events * fix one element type * refactor * add search resutls view events * comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first batch of events we're interested for tracking.
Also fixed a bug of creating datadoc from adhoc with templated variables.