Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add frontend context logging #1115

Merged
merged 5 commits into from
Jan 5, 2023
Merged

Conversation

jczhong84
Copy link
Collaborator

Add frontend instrument logging.

@jczhong84 jczhong84 marked this pull request as draft December 24, 2022 01:00
@jczhong84 jczhong84 marked this pull request as ready for review January 4, 2023 18:18


@register("/event_log/", methods=["POST"], api_logging=False)
def log_track_event(events: list):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

class FrontendEvent(TypedDict):
     timestamp: int
     event_data: dict
     event_type: str

@@ -62,7 +62,9 @@ def _api_deny_list(self) -> list:
},
]

def log(self, uid: int, event_type: EventType, event_data: dict):
def log(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use created_at field of EventLog?

@czgu czgu merged commit 6a951f8 into pinterest:master Jan 5, 2023
rohan-sh1 pushed a commit to CAI-TECHNOLOGIES/cai-ext-db-explorer that referenced this pull request Feb 28, 2023
* feat: add frontend context logging

* add batch call

* udpate comment

* created_at

* move to const file
@jczhong84 jczhong84 deleted the feat/analytics branch April 7, 2023 00:40
aidenprice pushed a commit to arrowtail-precision/querybook that referenced this pull request Jan 3, 2024
* feat: add frontend context logging

* add batch call

* udpate comment

* created_at

* move to const file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants