feat: a bunch of small ui fixes and improvements #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jczhong84
reviewed
Dec 23, 2022
| const cellIndexToFocus = this.focusCellIndexAfterInsert; | ||
| setImmediate(() => { | ||
| // setting focus cell during componentDidUpdate would not | ||
| // actually focus the cell, we need to do it in another thread |
There was a problem hiding this comment.
is it another thread or the next event loop?
querybook/webapp/components/DataTableViewQueryExample/DataTableViewQueryExamples.tsx
Outdated
Show resolved
Hide resolved
| @@ -283,6 +311,18 @@ const QueryExamplesList: React.FC<{ | |||
| className="DataTableViewQueryExamples-item" | |||
| key={query.id} | |||
| > | |||
| <div className="horizontal-space-between mb4"> | |||
There was a problem hiding this comment.
Personally I think it's better to have the title and Open Execution button top aligned instead of center aligned.
jczhong84
approved these changes
Dec 23, 2022
rohan-sh1
pushed a commit
to CAI-TECHNOLOGIES/cai-ext-db-explorer
that referenced
this pull request
Feb 28, 2023
* feat: a bunch of small ui fixes and improvements * comments
aidenprice
pushed a commit
to arrowtail-precision/querybook
that referenced
this pull request
Jan 3, 2024
* feat: a bunch of small ui fixes and improvements * comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features:
Fixes: