-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Visualize complex Hive column types v2 #1091
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
258 changes: 258 additions & 0 deletions
258
querybook/webapp/__tests__/lib/utils/complex-types.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,258 @@ | ||
| import { parseType, prettyPrintType } from 'lib/utils/complex-types'; | ||
|
|
||
| test('simple type', () => { | ||
| expect(parseType('column', 'string')).toEqual({ | ||
| key: 'column', | ||
| type: 'string', | ||
| }); | ||
| }); | ||
|
|
||
| test('truncated type', () => { | ||
| expect( | ||
| parseType( | ||
| 'column', | ||
| 'struct<date:struct<year:int,month:int,day:int>,hour:int,minute:int,second:int,' | ||
| ) | ||
| ).toEqual({ | ||
| key: 'column', | ||
| type: 'struct<date:struct<year:int,month:int,day:int>,hour:int,minute:int,second:int,', | ||
| }); | ||
|
|
||
| // Truncated, but coincidentally matches the regex | ||
| expect(parseType('column', 'struct<date:struct<hour:int>')).toEqual({ | ||
| key: 'column', | ||
| type: 'struct<date:struct<hour:int>', | ||
| }); | ||
| }); | ||
|
|
||
| test('malformed struct type', () => { | ||
| expect(parseType('column', 'STRUCT <id:string>')).toEqual({ | ||
| key: 'column', | ||
| type: 'STRUCT <id:string>', | ||
| }); | ||
| }); | ||
|
|
||
| test('complex type', () => { | ||
| expect(parseType('column', 'STRUCT<id:string>')).toEqual({ | ||
| key: 'column', | ||
| type: 'STRUCT<id:string>', | ||
| children: [ | ||
| { | ||
| key: 'id', | ||
| type: 'string', | ||
| }, | ||
| ], | ||
| }); | ||
|
|
||
| expect( | ||
| parseType( | ||
| 'column', | ||
| 'struct<date:struct<year:int,month:int,day:int>,hour:int,minute:int,second:int,timeZoneId:string>' | ||
| ) | ||
| ).toEqual({ | ||
| key: 'column', | ||
| type: 'struct<date:struct<year:int,month:int,day:int>,hour:int,minute:int,second:int,timeZoneId:string>', | ||
| children: [ | ||
| { | ||
| key: 'date', | ||
| type: 'struct<year:int,month:int,day:int>', | ||
| children: [ | ||
| { key: 'year', type: 'int' }, | ||
| { key: 'month', type: 'int' }, | ||
| { key: 'day', type: 'int' }, | ||
| ], | ||
| }, | ||
| { key: 'hour', type: 'int' }, | ||
| { key: 'minute', type: 'int' }, | ||
| { key: 'second', type: 'int' }, | ||
| { key: 'timeZoneId', type: 'string' }, | ||
| ], | ||
| }); | ||
|
|
||
| expect( | ||
| parseType( | ||
| 'column', | ||
| 'array<struct<size:struct<width:int,height:int,isAspectRatio:boolean>>>' | ||
| ) | ||
| ).toEqual({ | ||
| key: 'column', | ||
| type: 'array<struct<size:struct<width:int,height:int,isAspectRatio:boolean>>>', | ||
| children: [ | ||
| { | ||
| key: '<element>', | ||
| type: 'struct<size:struct<width:int,height:int,isAspectRatio:boolean>>', | ||
| children: [ | ||
| { | ||
| key: 'size', | ||
| type: 'struct<width:int,height:int,isAspectRatio:boolean>', | ||
| children: [ | ||
| { key: 'width', type: 'int' }, | ||
| { key: 'height', type: 'int' }, | ||
| { key: 'isAspectRatio', type: 'boolean' }, | ||
| ], | ||
| }, | ||
| ], | ||
| }, | ||
| ], | ||
| }); | ||
|
|
||
| expect( | ||
| parseType( | ||
| 'column', | ||
| 'struct<purchasePath:string,resultToken:string,sessionId:string,site:struct<eapid:bigint,tpid:bigint>,tests:array<struct<bucketValue:string,experimentId:string,instanceId:string>>,user:struct<guid:string,tuid:string>>' | ||
| ) | ||
| ).toEqual({ | ||
| key: 'column', | ||
| type: 'struct<purchasePath:string,resultToken:string,sessionId:string,site:struct<eapid:bigint,tpid:bigint>,tests:array<struct<bucketValue:string,experimentId:string,instanceId:string>>,user:struct<guid:string,tuid:string>>', | ||
| children: [ | ||
| { key: 'purchasePath', type: 'string' }, | ||
| { key: 'resultToken', type: 'string' }, | ||
| { key: 'sessionId', type: 'string' }, | ||
| { | ||
| key: 'site', | ||
| type: 'struct<eapid:bigint,tpid:bigint>', | ||
| children: [ | ||
| { key: 'eapid', type: 'bigint' }, | ||
| { key: 'tpid', type: 'bigint' }, | ||
| ], | ||
| }, | ||
| { | ||
| key: 'tests', | ||
| type: 'array<struct<bucketValue:string,experimentId:string,instanceId:string>>', | ||
| children: [ | ||
| { | ||
| key: '<element>', | ||
| type: 'struct<bucketValue:string,experimentId:string,instanceId:string>', | ||
| children: [ | ||
| { key: 'bucketValue', type: 'string' }, | ||
| { key: 'experimentId', type: 'string' }, | ||
| { key: 'instanceId', type: 'string' }, | ||
| ], | ||
| }, | ||
| ], | ||
| }, | ||
| { | ||
| key: 'user', | ||
| type: 'struct<guid:string,tuid:string>', | ||
| children: [ | ||
| { key: 'guid', type: 'string' }, | ||
| { key: 'tuid', type: 'string' }, | ||
| ], | ||
| }, | ||
| ], | ||
| }); | ||
|
|
||
| expect(parseType('column', 'map<string,float>')).toEqual({ | ||
| key: 'column', | ||
| type: 'map<string,float>', | ||
| children: [ | ||
| { | ||
| key: '<key>', | ||
| type: 'string', | ||
| }, | ||
| { | ||
| key: '<value>', | ||
| type: 'float', | ||
| }, | ||
| ], | ||
| }); | ||
|
|
||
| expect( | ||
| parseType( | ||
| 'column', | ||
| 'map<string,uniontype<string,int,bigint,float,double,struct<year:int,month:int,day:int>>>' | ||
| ) | ||
| ).toEqual({ | ||
| key: 'column', | ||
| type: 'map<string,uniontype<string,int,bigint,float,double,struct<year:int,month:int,day:int>>>', | ||
| children: [ | ||
| { | ||
| key: '<key>', | ||
| type: 'string', | ||
| }, | ||
| { | ||
| key: '<value>', | ||
| type: 'uniontype<string,int,bigint,float,double,struct<year:int,month:int,day:int>>', | ||
| children: [ | ||
| { key: '<element>', type: 'string' }, | ||
| { key: '<element>', type: 'int' }, | ||
| { key: '<element>', type: 'bigint' }, | ||
| { key: '<element>', type: 'float' }, | ||
| { key: '<element>', type: 'double' }, | ||
| { | ||
| key: '<element>', | ||
| type: 'struct<year:int,month:int,day:int>', | ||
| children: [ | ||
| { key: 'year', type: 'int' }, | ||
| { key: 'month', type: 'int' }, | ||
| { key: 'day', type: 'int' }, | ||
| ], | ||
| }, | ||
| ], | ||
| }, | ||
| ], | ||
| }); | ||
| }); | ||
|
|
||
| test('prettyPrintType', () => { | ||
| expect(prettyPrintType('map<string,string>')).toEqual(`map< | ||
| string, | ||
| string | ||
| >`); | ||
|
|
||
| expect( | ||
| prettyPrintType( | ||
| 'struct<ids:array<string>,data:uniontype<int,float,string>>' | ||
| ) | ||
| ).toEqual(`struct< | ||
| ids: array< | ||
| string | ||
| >, | ||
| data: uniontype< | ||
| int, | ||
| float, | ||
| string | ||
| > | ||
| >`); | ||
|
|
||
| expect( | ||
| prettyPrintType( | ||
| 'struct<ids:array<string>,comment:string,data:map<int,int>>' | ||
| ) | ||
| ).toEqual(`struct< | ||
| ids: array< | ||
| string | ||
| >, | ||
| comment: string, | ||
| data: map< | ||
| int, | ||
| int | ||
| > | ||
| >`); | ||
|
|
||
| expect( | ||
| prettyPrintType( | ||
| 'map<struct<ids:array<string>,comment:string,data:map<int,int>>,struct<data:array<string>,event:map<int,int>>>' | ||
| ) | ||
| ).toEqual(`map< | ||
| struct< | ||
| ids: array< | ||
| string | ||
| >, | ||
| comment: string, | ||
| data: map< | ||
| int, | ||
| int | ||
| > | ||
| >, | ||
| struct< | ||
| data: array< | ||
| string | ||
| >, | ||
| event: map< | ||
| int, | ||
| int | ||
| > | ||
| > | ||
| >`); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58 changes: 58 additions & 0 deletions
58
querybook/webapp/components/DataTableViewColumn/DataTableColumnCardNestedType.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| import * as React from 'react'; | ||
|
|
||
| import { ComplexType } from 'lib/utils/complex-types'; | ||
| import { IconButton } from 'ui/Button/IconButton'; | ||
| import { AccentText, StyledText } from 'ui/StyledText/StyledText'; | ||
|
|
||
| interface IDataTableColumnCardNestedTypeProps { | ||
| complexType: ComplexType; | ||
| } | ||
| export const DataTableColumnCardNestedType: React.FunctionComponent< | ||
| IDataTableColumnCardNestedTypeProps | ||
| > = ({ complexType }) => { | ||
| const hasChildren = complexType.children?.length > 0; | ||
| const [expanded, setExpanded] = React.useState(false); | ||
|
|
||
| const rowProps: React.HTMLAttributes<HTMLDivElement> = { | ||
| className: 'flex-row', | ||
| }; | ||
|
|
||
| if (hasChildren) { | ||
| rowProps['onClick'] = () => setExpanded(!expanded); | ||
| rowProps['aria-label'] = expanded | ||
| ? 'click to collapse' | ||
| : 'click to expand'; | ||
| rowProps['data-balloon-pos'] = 'down-left'; | ||
| } | ||
|
|
||
| return ( | ||
| <div className="DataTableColumnCardNestedType"> | ||
| <div {...rowProps}> | ||
| {hasChildren && ( | ||
| <IconButton | ||
| icon={expanded ? 'Minus' : 'Plus'} | ||
| size="16" | ||
| noPadding={true} | ||
| className="expand-icon" | ||
| /> | ||
| )} | ||
| <AccentText weight="extra" className="mr12"> | ||
| {complexType.key} | ||
| </AccentText> | ||
| <StyledText | ||
| color="light" | ||
| className={`column-type ${!hasChildren && 'nested-indent'}`} | ||
| > | ||
| {complexType.type} | ||
| </StyledText> | ||
| </div> | ||
| {hasChildren && | ||
| expanded && | ||
| complexType.children.map((child) => ( | ||
| <div className="nested-indent m16" key={child.key}> | ||
| <DataTableColumnCardNestedType complexType={child} /> | ||
| </div> | ||
| ))} | ||
| </div> | ||
| ); | ||
| }; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can use
useToggleStatethen you don't need() => setExpanded(!expanded)