Properly handle --stdin flag for printAST command #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shashachu
commented
Jul 16, 2019
| @@ -77,6 +77,6 @@ internal class PrintASTSubCommand : Runnable { | |||
|
|
|||
| companion object { | |||
| internal const val COMMAND_NAME = "printAST" | |||
| private const val STDIN_FILE = "<stdin>" | |||
| private const val STDIN_FILE = "<text>" | |||
There was a problem hiding this comment.
the code explicitly uses this as a flag for stdin. we should probably move this into a constant somewhere.
There was a problem hiding this comment.
Sorry, missed that as it is not a constant. Yes, you are right - would be better to add const val STDIN_FILE_NAME = "<stdin>" in https://github.com/pinterest/ktlint/blob/master/ktlint-core/src/main/kotlin/com/pinterest/ktlint/core/KtLint.kt and use it here and in other places, so in the future it will not happen again.
Generally, I think, we should bring some integration test to command line module.
There was a problem hiding this comment.
@Tapchicoma updated with the constant Edit: and no need to apologize; I didn't notice in review either.
* Fixes pinterest#528 * Also properly pass through `--debug` flag from `printAST` command * Small cleanup of unused variable
sowmyav24
pushed a commit
to sowmyav24/ktlint
that referenced
this pull request
Jul 18, 2019
* Properly handle --stdin flag for printAST command * Fixes pinterest#528 * Also properly pass through `--debug` flag from `printAST` command * Small cleanup of unused variable * move stdin to constant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--debugflag fromprintASTcommand