Add tests for missing rules in a ruleset #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romtsn
commented
Jun 10, 2019
|
|
||
| open class RuleSetProviderTest( | ||
| private val rulesetClass: Class<out RuleSetProvider>, | ||
| private val packageName: String |
There was a problem hiding this comment.
nit: We could, in theory, get the package name from rulesetClass and this would work with current ktlint structure, but in case of custom rulesets, the rules could be located in a different folder, so I would rather leave it like that
romtsn
commented
Jun 10, 2019
| import org.junit.Test | ||
| import java.io.File | ||
|
|
||
| open class RuleSetProviderTest( |
There was a problem hiding this comment.
I'm not sure that this is the best way for the centralized test code - this could be just a simple top-level function, which may be called from within a test method (e.g. in case StandardRuleSetProviderTest contains other tests), so I'm open for changing this, but currently it works.
|
This looks like a reasonable approach to me. We can merge it in the future. |
romtsn
force-pushed
the
missing-rules-in-ruleset
branch
from
662ef4d to
2a12348
Compare
|
@shashachu updated the PR accordingly. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up for #476. I would suggest merging this after the
.ktlintignorelanded onmaster. Or I could also implement ignores list for this kind of tests for now, but I would rather wait for global ignores. It just grabs the source files from the specified location and then checks that all of them are being returned from the specified ruleset.