Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process of migrating to gradle - organize gradle dependencies #460

Merged
merged 1 commit into from
Jun 8, 2019
Merged

Process of migrating to gradle - organize gradle dependencies #460

merged 1 commit into from
Jun 8, 2019

Conversation

jaredsburrows
Copy link
Contributor

#445

@shashachu

Clean up and organize Gradle dependencies across the project. This is similar to other open source Gradle projects such as https://github.com/JakeWharton/SdkSearch/blob/master/build.gradle#L18.

@shashachu
Copy link
Contributor

Interesting! I've never seen this particular format. Very nice.

@shashachu
Copy link
Contributor

BTW, probably outside the scope of this migration, but I'd love to eventually port the build scripts to kotlin as well.

@shashachu shashachu merged commit 6a34595 into pinterest:master Jun 8, 2019
@jaredsburrows
Copy link
Contributor Author

@shashachu I can make a PR for that as well.

@jaredsburrows jaredsburrows deleted the pr/jaredsburrows/clean-up-build.gradles branch June 8, 2019 16:28
sowmyav24 pushed a commit to sowmyav24/ktlint that referenced this pull request Jun 9, 2019
sowmyav24 pushed a commit to sowmyav24/ktlint that referenced this pull request Jun 9, 2019
sowmyav24 pushed a commit to sowmyav24/ktlint that referenced this pull request Jun 9, 2019
sowmyav24 pushed a commit to sowmyav24/ktlint that referenced this pull request Jun 10, 2019
sowmyav24 pushed a commit to sowmyav24/ktlint that referenced this pull request Jun 10, 2019
sowmyav24 pushed a commit to sowmyav24/ktlint that referenced this pull request Jun 10, 2019
sowmyav24 pushed a commit to sowmyav24/ktlint that referenced this pull request Jun 10, 2019
sowmyav24 pushed a commit to sowmyav24/ktlint that referenced this pull request Jun 10, 2019
sowmyav24 pushed a commit to sowmyav24/ktlint that referenced this pull request Jun 10, 2019
sowmyav24 pushed a commit to sowmyav24/ktlint that referenced this pull request Jun 10, 2019
sowmyav24 pushed a commit to sowmyav24/ktlint that referenced this pull request Jun 10, 2019
@romtsn
Copy link
Collaborator

romtsn commented Jun 10, 2019

@jaredsburrows Btw, it's already too late to ask, but is there a specific reason of not using the implementation/api instead of compile? Just noticed that.

@jaredsburrows
Copy link
Contributor Author

@rom4ek This CL was to organize the dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants