Process of migrating to gradle - update gradle to 5.4.1

[jaredsburrows]

#445

@shashachu

Update gradle to 5.4.1

[JLLeitschuh]

Moving forward, please ensure the validity of the Gradle wrapper jar before merging in the future.

I know @jaredsburrows is trusted, but in general, a PR with a giant blob of binary should always be checked for validity.

https://docs.gradle.org/current/userguide/gradle_wrapper.html#wrapper_checksum_verification

[jaredsburrows]

You would think that this would be build into the wrapper.

[shashachu]

@JLLeitschuh good call-out. Thanks

[JLLeitschuh]

You would think that this would be build into the wrapper.

You're referring to the gradlew and gradlew.bat files? It could be done that way, but then every Gradle launch would have the added overhead of an SHA checksum check and network access.

Feel free to open an issue with gradle/gradle if you want to discuss this idea and I can discuss it with the team internally. (I start with Gradle officially on June 17th).