Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kotlin monorepo to v2 (major) #2666

Merged
merged 3 commits into from
Jul 9, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
java-compilation = "21"
# The java-target version is the lowest supported LTS version of Java. Jar's produced are bytecode compatible with this version.
java-target = "8"
kotlin = "1.9.24"
kotlinDev = "1.9.24"
kotlin = "2.0.0"
kotlinDev = "2.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically you're right that we can update this. But honestly, I do not have the idea that anyone is using a snapshot version, let alone the dev-snapshot version. Recently it was broken for several weeks, without anybody noticing it.


[plugins]
kotlin-jvm = { id = "org.jetbrains.kotlin.jvm", version.ref = "kotlin" }
Expand All @@ -21,7 +21,7 @@ dokka = "org.jetbrains.dokka:dokka-gradle-plugin:1.9.20"
ec4j = "org.ec4j.core:ec4j-core:0.3.0"
logging = "io.github.oshai:kotlin-logging-jvm:6.0.9"
slf4j = "org.slf4j:slf4j-simple:2.0.13"
poko = "dev.drewhamilton.poko:poko-gradle-plugin:0.15.3"
poko = "dev.drewhamilton.poko:poko-gradle-plugin:0.16.0"
# Use logback-classic as the logger for kotlin-logging / slf4j as it allow changing the log level at runtime.
# TODO: Update "renovate.json" once logback-classic is updated to 1.4 (once java8 support for ktlint is dropped)
logback = "ch.qos.logback:logback-classic:1.3.14"
Expand Down