-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add maven relocation #2282
Add maven relocation #2282
Conversation
…ter-baseline` When publishing to the local Maven repository, a `0.51.0-FINAL` version of the `pom.xml` is created for the modules above. The modules contain the expected content. But the `pom.xml` is missing the signature. Another side effect is that the `1.0.1-SNAPSHOT` version of the modules above is not created anymore as the `signing` block is now added to the module. In 1.0.0 more modules have been relocated. They need to be added as well when it is clear how this should be approached.
@Goooler Can you please help me out with this change? I have sent a slack message a while ago with more details. |
|
||
publishing { | ||
publications { | ||
// TODO: Remove in release after ktlint 1.0.1 | ||
create<MavenPublication>("relocation-ktlint-cli-reporter-baseline") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not be familiar with maven relocation, but if you wan't to sign this, could add something like:
signing {
sign(publishing.publications["relocation-ktlint-cli-reporter-baseline"])
}
Ref:
sign(publishing.publications["maven"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My question is not specifically about the maven relocation, but how to avoid code duplication in Gradle build. I have now added a publication
and signing
block in each module for which the maven coordinate has been changed. It is good enough as it will be removed soon.
And if this is only for maven coordinate relocation, can we rebase this PR to |
…nates where changed in 1.0.0 release Closes #2280
I don't know how to create a release from a branch. I might not have enough privileges for that. I have tested on my local machine that publish to maven local creates both artifacts for |
Description
Add maven relocation block to
ktlint-cli
andktlint-cli-reporter-baseline
When publishing to the local Maven repository, a
0.51.0-FINAL
version of thepom.xml
is created for the modules above. The modules contain the expected content. But thepom.xml
is missing the signature. Another side effect is that the1.0.1-SNAPSHOT
version of the modules above is not created anymore as thesigning
block is now added to the module.In 1.0.0 more modules have been relocated. They need to be added as well when it is clear how this should be approached.
Checklist
Before submitting the PR, please check following (checks which are not relevant may be ignored):
Closes #<xxx>
orFixes #<xxx>
(replace<xxx>
with issue number)CHANGELOG.md
is updatedDocumentation is updated. See difference between snapshot and release documentation