-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes/2017/ignore serial version UI d #2045
Fixes/2017/ignore serial version UI d #2045
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...t-standard/src/main/kotlin/com/pinterest/ktlint/ruleset/standard/rules/PropertyNamingRule.kt
Outdated
Show resolved
Hide resolved
...andard/src/test/kotlin/com/pinterest/ktlint/ruleset/standard/rules/PropertyNamingRuleTest.kt
Outdated
Show resolved
Hide resolved
...andard/src/test/kotlin/com/pinterest/ktlint/ruleset/standard/rules/PropertyNamingRuleTest.kt
Outdated
Show resolved
Hide resolved
...andard/src/test/kotlin/com/pinterest/ktlint/ruleset/standard/rules/PropertyNamingRuleTest.kt
Outdated
Show resolved
Hide resolved
45c1ab9
to
2d51a69
Compare
4902325
to
bf9eb22
Compare
I have update your PR. Next time, please update changelog. Also, in chained methods please write:
instead of
|
I can (will) not merge this PR. It still contains changes of another PR which results in merge conflicts above. Please start a new PR and only commit the relevant changes to that PR. Please whenever you start a new PR, please be sure to create a new branch from latest remote master. |
Hi, @paul-dingemans sorry for the inconvenience. let me look into it. If you see the file changes you will see that there is no changes from the previous PR. And if I remember correctly I dropped those commits hard pushed yesterday. But anyway let me look into it again |
a0f9c69
to
d86bbec
Compare
Hi @paul-dingemans just to be clear you are suggesting to use below style?
I am asking as the existing code in
|
No, I meant that
Should be on same line, like
|
Description
Filter the
serialversionUID
from the analysisFixes #2017
Checklist
CHANGELOG.md
is updated