Fix version returning null when running on Java 9 #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bug in JDK-9 [JDK-8190987](https://bugs.openjdk.java.net/browse/JDK-8190987) caused `Package.getImplementationVersion()` to return null. This commits adds code to read the Manifest file from the JAR to get the Implementation Version when it's not possible to retreive the version through the normal way.
|
Thank you, @ifrins! 👍 Merging in. |
shyiko
added a commit
that referenced
this pull request
Feb 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug in JDK-9 (JDK-8190987) caused
Package.getImplementationVersion()to return null. This commits adds code to read the Manifest file from the JAR to get the Implementation Version when it's not possible to retrieve the version through the normal way.This PR contributes to #152